Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support concatenated callables in RenderCallbackRule #544

Merged
merged 4 commits into from
May 10, 2023
Merged

Support concatenated callables in RenderCallbackRule #544

merged 4 commits into from
May 10, 2023

Conversation

Boegie
Copy link
Contributor

@Boegie Boegie commented Apr 28, 2023

Will resolve #543

@Boegie Boegie mentioned this pull request Apr 28, 2023
Closed
@Boegie
Copy link
Contributor Author

Boegie commented Apr 29, 2023

Originally, being a UnionType, the callback ended up here:

phpstan-drupal/src/Rules/Drupal/RenderCallbackRule.php

Line 194 in ed32c28

return null;
, so rather unchecked.

Since we have an array of ConstantStringType, I've tried to check it.

@mglaman
Copy link
Owner

mglaman commented Apr 30, 2023

Ah thanks, I overlooked this test case in the fix. I'll review when at my laptop and make a fix ASAP.

@mglaman mglaman changed the title PR for #543 TrustedCallback attribute regression for constant string types May 10, 2023
@mglaman mglaman changed the title TrustedCallback attribute regression for constant string types Support concatenated callables in RenderCallbackRule May 10, 2023
@mglaman mglaman merged commit 7340cbc into mglaman:main May 10, 2023
@Boegie Boegie deleted the 543 branch May 10, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mglaman mglaman mglaman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concatenated callables treated as union type, used to be skipped on RenderCallbackRule
2 participants
@Boegie @mglaman